Re: [PATCH] sysrq: Allow access to sensitive keys to be restricted by default

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Sep 29, 2013 at 09:40:09PM -0400, Dave Jones wrote:
> On Mon, Sep 30, 2013 at 02:31:08AM +0100, Ben Hutchings wrote:
>  > From: Bastian Blank <waldi@debian.org>
>  > 
>  > Add a Kconfig variable to set the initial value of the Magic SysRq mask
>  > (sysctl: kernel.sysrq).
>  > 
>  > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>  > ---
>  > This has been in Debian for a while, but should probably be signed-off
>  > by Bastian as well.
>  > 
>  > Debian sets this to 0x01b6, which excludes.
>  > 
>  >           8 - enable debugging dumps of processes etc.
>  >          64 - enable signalling of processes (term, kill, oom-kill)
>  > ...
>  >  
>  > +config MAGIC_SYSRQ_DEFAULT_MASK
>  > +	hex "Default mask for Magic SysRq keys on the console"
>  > +	depends on MAGIC_SYSRQ
>  > +	default 1
>  > +	help
>  > +	  Specifies the default mask for the allowed SysRq keys.  This can be
>  > +	  used to disable several sensitive keys by default.
> 
> Might be nice to have the mask values duplicated here to save having to
> go grepping through code ?

Yeah, a hit would be good.  Like what '1' does as default would be a
nice start :)

thanks,

greg k-h