From: Tejun Heo <tj@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: Libin <huawei.libin@huawei.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] [workqueue] check values of pwq and wq in print_worker_info() before use
Date: Tue, 1 Oct 2013 17:03:48 -0400 [thread overview]
Message-ID: <20131001210348.GB27149@mtj.dyndns.org> (raw)
In-Reply-To: <524B364B.3010405@gmx.de>
On Tue, Oct 01, 2013 at 10:53:31PM +0200, Helge Deller wrote:
> So, in summary my patch here is not really necessary, but for the sake of
> clean code I think it doesn't hurt either and as such it would be nice if
> you could apply it.
What? function *must* take any value and try to access it and not
cause failure. That's the *whole* purpose of that interface. How is
having incomplete spurious checks around it "clean code" in any sense
of the word? That doesn't make any sense.
Nacked-by: Tejun Heo <tj@kernel.org>
and *please* don't add any checks like that anywhere else in the
kernel.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-10-01 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 20:35 Helge Deller
2013-10-01 20:43 ` Tejun Heo
2013-10-01 20:53 ` Helge Deller
2013-10-01 21:03 ` Tejun Heo [this message]
2013-10-01 21:07 ` Tejun Heo
2013-10-01 22:34 ` Helge Deller
2013-10-01 22:40 ` Tejun Heo
2013-10-01 22:47 ` Tejun Heo
2013-10-01 21:40 ` James Bottomley
2013-10-01 22:07 ` Helge Deller
2013-10-01 22:50 ` James Bottomley
2013-10-02 0:41 ` John David Anglin
2013-10-02 1:58 ` John David Anglin
2013-10-02 8:28 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001210348.GB27149@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=deller@gmx.de \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®