From: Francois Romieu <romieu@fr.zoreil.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Ruslan N. Marchenko" <me@ruff.mobi>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
Date: Wed, 2 Oct 2013 00:45:15 +0200 [thread overview]
Message-ID: <20131001224515.GA3113@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309301342530.2036@localhost6.localdomain6>
Julia Lawall <julia.lawall@lip6.fr> :
[...]
> There has already been a discussion about this, and a patch has already
> been proposed. It has to do with lock managament. I will look for the
> email.
The underlying problem has to do with disabled irq. netif_receive_skb
assumes irq to be enabled. Current via-velocity poll() method should
narrow its (spinlocked) irq disabled section.
What I've done should not require much analysis (aka "what could race
with the rx bh processing in a napi driver ?") and avoids a more intrusive
lockless napi design.
--
Ueimor
next prev parent reply other threads:[~2013-10-01 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 7:15 Ruslan N. Marchenko
2013-09-30 11:43 ` Julia Lawall
2013-10-01 22:45 ` Francois Romieu [this message]
2013-09-30 11:54 ` Julia Lawall
2013-09-30 13:54 ` Ruslan N. Marchenko
2013-10-01 6:29 ` Ruslan N. Marchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001224515.GA3113@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=me@ruff.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®