From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Dirk Gouders <dirk@gouders.net>
Cc: "Martin Walch" <walch.martin@web.de>,
"Michal Marek" <mmarek@suse.cz>,
"Jiri Kosina" <trivial@kernel.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Benjamin Poirier" <bpoirier@suse.de>,
"Wang YanQing" <udknight@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Kees Cook" <keescook@chromium.org>,
"Alan Cox" <alan@linux.intel.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] kconfig: remove unused definition from scanner
Date: Wed, 2 Oct 2013 08:57:54 +0200 [thread overview]
Message-ID: <201310020857.54800.yann.morin.1998@free.fr> (raw)
In-Reply-To: <ghk3hwjhqk.fsf@lena.gouders.net>
Martin, All,
On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> Martin Walch <walch.martin@web.de> writes:
>
> > From: Martin Walch <walch.martin@web.de>
> > Date: Wed, 2 Oct 2013 06:58:46 +0200
> > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
> >
> > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
>
> Hi Martin,
>
> I think you should also regenerate the scanner and add
> the new zconf.lex.c_shipped to this patch.
I think sending the re-generated parser as a separate patch helps
in reviewing. Ie. I'd prefer a fifth patch.
BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config
Regards,
Yann E. MORIN.
> > Signed-off-by: Martin Walch <walch.martin@web.de>
> > ---
> > scripts/kconfig/zconf.l | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> > index 6555a47..1a9f53e 100644
> > --- a/scripts/kconfig/zconf.l
> > +++ b/scripts/kconfig/zconf.l
> > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> > }
> > %}
> >
> > -ws [ \n\t]
> > n [A-Za-z0-9_]
> >
> > %%
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
next prev parent reply other threads:[~2013-10-02 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 5:24 Martin Walch
2013-10-02 6:42 ` Dirk Gouders
2013-10-02 6:57 ` Yann E. MORIN [this message]
2013-10-03 0:30 ` Martin Walch
2013-10-03 6:37 ` Yann E. MORIN
2013-10-03 13:13 ` Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310020857.54800.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=arve@android.com \
--cc=bpoirier@suse.de \
--cc=dirk@gouders.net \
--cc=jdelvare@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=trivial@kernel.org \
--cc=udknight@gmail.com \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®