From: David Miller <davem@davemloft.net>
To: hns@goldelico.com
Cc: j.dumon@option.com, marek.belisko@gmail.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication
Date: Thu, 03 Oct 2013 16:00:49 -0400 (EDT) [thread overview]
Message-ID: <20131003.160049.199880461500344692.davem@davemloft.net> (raw)
In-Reply-To: <C7520082-95CC-4D4F-BCE4-96A7D6346DB3@goldelico.com>
From: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Date: Thu, 3 Oct 2013 21:40:34 +0200
> I have made the bug observation from debug log that this bit is set in a response
> each time the modem has a RING message. It might be specific to this modem
> and firmware version, i.e. a firmware bug. But we have no means to verify or even
> change it in the firmware.
>
> I.e. the driver must handle it in a better way.
>
> Because the notification is rejected by the driver, the driver will hang up and the
> whole modem connection breaks down.
>
> With this patch, the problem was never observed again in ~2 years.
>
> I'd hope the maintainer of this driver can shed some light on it.
I think if you suspect the bit is set in response to RING messages
then you should define a macro so that the number is not just magic,
and put a descriptrive comment above the macro definition for that
bit.
next prev parent reply other threads:[~2013-10-03 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 7:00 Dr. H. Nikolaus Schaller
2013-10-03 19:29 ` David Miller
2013-10-03 19:40 ` Dr. H. Nikolaus Schaller
2013-10-03 20:00 ` David Miller [this message]
2013-10-04 6:22 ` Dr. H. Nikolaus Schaller
2013-12-13 14:43 ` Dr. H. Nikolaus Schaller
2013-12-16 19:40 ` Dan Williams
2013-12-17 19:56 ` Dr. H. Nikolaus Schaller
2013-12-17 22:27 ` Dan Williams
2013-12-18 13:16 ` Dr. H. Nikolaus Schaller
2013-12-18 17:49 ` Dan Williams
2013-12-19 7:48 ` Dr. H. Nikolaus Schaller
2014-01-06 16:07 ` [PATCH] hso: fix handling of modem port SERIAL_STATE notifications Dan Williams
2014-01-06 21:30 ` David Miller
2014-01-06 21:39 ` Dan Williams
2014-01-06 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003.160049.199880461500344692.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hns@goldelico.com \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®