From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280Ab3JCEAg (ORCPT ); Thu, 3 Oct 2013 00:00:36 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:57974 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642Ab3JCEAe (ORCPT ); Thu, 3 Oct 2013 00:00:34 -0400 Date: Thu, 3 Oct 2013 13:00:31 +0900 From: Simon Horman To: Sergei Shtylyov Cc: vinod.koul@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls Message-ID: <20131003040031.GA7925@verge.net.au> References: <201309260228.37765.sergei.shtylyov@cogentembedded.com> <20130926021417.GC18396@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130926021417.GC18396@verge.net.au> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 26, 2013 at 11:14:17AM +0900, Simon Horman wrote: > On Thu, Sep 26, 2013 at 02:28:37AM +0400, Sergei Shtylyov wrote: > > Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed > > resource allocation) got rid of shdma_free_irq() but unfortunately got merged > > later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for > > R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken: > > > > drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources': > > drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function > > `shdma_free_irq' > > > > Fix this compilation error by removing the remaining shdma_free_irq() calls. > > Tested-by: Simon Horman > > > Reported-by: Simon Horman > > Signed-off-by: Sergei Shtylyov Vinod, could you consider taking this and the following patch as a fix for v3.12?