mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"mcgrathr@chromium.org" <mcgrathr@chromium.org>,
	arnd@arndb.de, rostedt@goodmis.org, fweisbec@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] asm-generic: syscall_get/set_arguments accept zero for number of arguments
Date: Thu, 3 Oct 2013 17:18:17 +0100	[thread overview]
Message-ID: <20131003161817.GB7408@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1380779266-11753-4-git-send-email-takahiro.akashi@linaro.org>

[extending CC list to add the ftrace guys]

On Thu, Oct 03, 2013 at 06:47:46AM +0100, AKASHI Takahiro wrote:
> There is a possibility of calling syscall_get_arguments() with zero as
> 'number of arguments(n)' in ftrace_syscall_enter().
> The comments in syscall_get_argumets() as well as syscall_set_arugments()
> are corrected to clarify that.

Probably also worth mentioning that all architectures deal with n + i == 0
(after your first two patches fixing up arm and arm64, anyway).

> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  include/asm-generic/syscall.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-generic/syscall.h b/include/asm-generic/syscall.h
> index 5b09392..49b35ab 100644
> --- a/include/asm-generic/syscall.h
> +++ b/include/asm-generic/syscall.h
> @@ -106,7 +106,7 @@ void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs,
>   * @task:	task of interest, must be blocked
>   * @regs:	task_pt_regs() of @task
>   * @i:		argument index [0,5]
> - * @n:		number of arguments; n+i must be [1,6].
> + * @n:		number of arguments; n+i must be [0,6].
>   * @args:	array filled with argument values
>   *
>   * Fetches @n arguments to the system call starting with the @i'th argument
> @@ -126,7 +126,7 @@ void syscall_get_arguments(struct task_struct *task, struct pt_regs *regs,
>   * @task:	task of interest, must be in system call entry tracing
>   * @regs:	task_pt_regs() of @task
>   * @i:		argument index [0,5]
> - * @n:		number of arguments; n+i must be [1,6].
> + * @n:		number of arguments; n+i must be [0,6].
>   * @args:	array of argument values to store
>   *
>   * Changes @n arguments to the system call starting with the @i'th argument.

Acked-by: Will Deacon <will.deacon@arm.com>

Will

           reply	other threads:[~2013-10-03 16:18 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1380779266-11753-4-git-send-email-takahiro.akashi@linaro.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131003161817.GB7408@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=arnd@arndb.de \
    --cc=fweisbec@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrathr@chromium.org \
    --cc=rostedt@goodmis.org \
    --cc=takahiro.akashi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®