From: Guenter Roeck <linux@roeck-us.net>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 8/9] watchdog: sp805_wdt: Remove unnecessary amba_set_drvdata()
Date: Thu, 3 Oct 2013 09:47:01 -0700 [thread overview]
Message-ID: <20131003164701.GB31605@roeck-us.net> (raw)
In-Reply-To: <7a51da3b47e0dd14d9ad13853f649463dba9350f.1380793579.git.michal.simek@xilinx.com>
On Thu, Oct 03, 2013 at 11:46:30AM +0200, Michal Simek wrote:
> Driver core clears the driver data to NULL after device_release
> or on probe failure, so just remove it from here.
>
> Driver core change:
> "device-core: Ensure drvdata = NULL when no driver is bound"
> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> drivers/watchdog/sp805_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index 58df98a..3f786ce 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -268,7 +268,6 @@ static int sp805_wdt_remove(struct amba_device *adev)
> struct sp805_wdt *wdt = amba_get_drvdata(adev);
>
> watchdog_unregister_device(&wdt->wdd);
> - amba_set_drvdata(adev, NULL);
> watchdog_set_drvdata(&wdt->wdd, NULL);
This one is quite unnecessary as well. The wdt data structure will be freed
as part of the removal. That could be a separate patch, though, so still
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
If you like, feel free to resubmit with the watchdog_set_drvdata() removed
and keep my Reviewed-by.
Thanks,
Guenter
>
> return 0;
> --
> 1.8.2.3
>
next prev parent reply other threads:[~2013-10-03 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 9:46 [PATCH 1/9] dma: pl330: " Michal Simek
2013-10-03 9:46 ` [PATCH 2/9] input: ambakmi: " Michal Simek
2013-10-03 9:46 ` [PATCH 3/9] ARM: etm: " Michal Simek
2013-10-03 9:46 ` [PATCH 4/9] mmc: mmci: " Michal Simek
2013-10-03 9:46 ` [PATCH 5/9] rtc: amba: " Michal Simek
2013-10-03 9:46 ` [PATCH 6/9] serial: " Michal Simek
2013-10-03 9:46 ` [PATCH 7/9] spi: pl022: " Michal Simek
2013-10-03 13:07 ` Mark Brown
2013-10-03 9:46 ` [PATCH 8/9] watchdog: sp805_wdt: " Michal Simek
2013-10-03 16:47 ` Guenter Roeck [this message]
2013-10-29 7:49 ` Wim Van Sebroeck
2013-10-03 9:46 ` [PATCH 9/9] video: amba-clcd: " Michal Simek
2013-10-09 8:44 ` Tomi Valkeinen
2013-10-31 14:25 ` [PATCH 1/9] dma: pl330: " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003164701.GB31605@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®