mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: takasi-y@ops.dti.ne.jp
To: Magnus Damm <magnus.damm@gmail.com>
Cc: SH-Linux <linux-sh@vger.kernel.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>,
	devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Paul Mundt <lethal@linux-sh.org>,
	Mike Turquette <mturquette@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT
Date: Fri, 4 Oct 2013 14:44:43 +0900	[thread overview]
Message-ID: <20131004144443.a7590dd81b8901ef264e488f@ops.dti.ne.jp> (raw)
In-Reply-To: <CANqRtoRD35Ei31PK8a_TOp=2uiYPCoaJuDb6tyZtQL8s0PavNw@mail.gmail.com>

Hi Magnus,
Thank you for your commnets.

> > +obj-$(CONFIG_ARCH_SHMOBILE)    += shmobile/
> > +obj-$(CONFIG_ARCH_SHMOBILE_MULTI)      += shmobile/
> 
> Here I believe it is enough that you only use
> CONFIG_ARCH_SHMOBILE_MULTI. ...

That is because it supports three configuration,
1. MULTI + KZM9D_REFERENCE + COMMON_CLK
2. KZM9D_REFERENCE + COMMON_CLK
3. KZM9D
but,

> ... Building common clocks to coexist with the
> old legacy board code does not make any sense IMO. ...
I think so, too.
And from the view of testing, having smaller variants is better.
# easier :)

> > +ifeq ($(CONFIG_COMMON_CLK), y)
> > +obj-$(CONFIG_ARCH_EMEV2)       += clk-emev2.o
> > +endif
> 
> I don't think you would need the above ifeq/endif wrapper if you only
> used CONFIG_ARCH_SHMOBILE_MULTI above.
Right.

Anyway, because you have make kzm9d-reference things simpler,
now we don't need to worry about it.

Thanks,
/yoshii

  parent reply	other threads:[~2013-10-04  5:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24  4:05 [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework " Takashi Yoshii
2013-09-24  4:09 ` [PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare takasi-y
2013-09-24  4:42   ` Simon Horman
2013-09-26 10:18     ` Daniel Lezcano
2013-10-03  2:30       ` Simon Horman
2013-09-30 15:25   ` Laurent Pinchart
2013-10-01  9:05   ` Magnus Damm
2013-09-24  4:10 ` [PATCH 2/6] serial8250-em: " takasi-y
2013-09-24  4:44   ` Simon Horman
2013-09-24 13:41     ` Greg Kroah-Hartman
2013-10-03  2:30       ` Simon Horman
2013-09-30 15:25   ` Laurent Pinchart
2013-10-01  9:07   ` Magnus Damm
2013-09-24  4:12 ` [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively takasi-y
2013-09-30 18:40   ` Laurent Pinchart
2013-10-04  5:25     ` takasi-y
2013-10-01  9:30   ` Magnus Damm
2013-09-24  4:13 ` [PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings takasi-y
2013-09-24  4:52   ` Simon Horman
2013-09-24  9:00     ` takashi.yoshii.zj
2013-10-01 11:36     ` Laurent Pinchart
2013-10-02  1:28       ` Simon Horman
2013-10-06 17:16       ` Takashi YOSHII
2013-09-24  4:15 ` [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT takasi-y
2013-10-01  9:15   ` Magnus Damm
2013-10-01 12:27     ` Laurent Pinchart
2013-10-04  5:44     ` takasi-y [this message]
2013-09-24  4:17 ` [PATCH 6/6] ARM: shmobile: kzm9d-reference: Use common clock framework takasi-y
2013-09-24  4:55   ` Simon Horman
2013-10-01  9:23   ` Magnus Damm
2013-09-24  4:56 ` [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT Simon Horman
2013-09-25  7:17 ` Kuninori Morimoto
2013-10-04  1:12   ` takasi-y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131004144443.a7590dd81b8901ef264e488f@ops.dti.ne.jp \
    --to=takasi-y@ops.dti.ne.jp \
    --cc=ben.dooks@codethink.co.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=shinya.kuribayashi.px@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®