mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Clean up cap_user_time* setting
Date: Fri, 4 Oct 2013 20:55:39 +0200	[thread overview]
Message-ID: <20131004185539.GT15690@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <524F097A.9010506@intel.com>

On Fri, Oct 04, 2013 at 09:31:22PM +0300, Adrian Hunter wrote:
> On 4/10/2013 8:31 p.m., tip-bot for Peter Zijlstra wrote:
> >Commit-ID:  d8b11a0cbd1c66ce283eb9dabe0498dfa6483f32
> >Gitweb:     http://git.kernel.org/tip/d8b11a0cbd1c66ce283eb9dabe0498dfa6483f32
> >Author:     Peter Zijlstra <peterz@infradead.org>
> >AuthorDate: Thu, 3 Oct 2013 16:00:14 +0200
> >Committer:  Ingo Molnar <mingo@kernel.org>
> >CommitDate: Fri, 4 Oct 2013 09:58:55 +0200
> >
> >perf/x86: Clean up cap_user_time* setting
> >
> >Currently the cap_user_time_zero capability has different tests than
> >cap_user_time; even though they expose the exact same data.
> >
> >Switch from CONSTANT && NONSTOP to sched_clock_stable to also deal
> >with multi cabinet machines and drop the tsc_disabled() check.. non of
> >this will work sanely without tsc anyway.
> 
> Unfortunately in the case that TSC is disabled, sched_clock is still
> reported as stable, which means removing the tsc_disabled() check breaks
> the capability bit. e.g.

I'm wanting to hear from the x86 people on why we have this absurd knob
to begin with; but I'm tempted to simply disable all of perf if you
touch it.

  reply	other threads:[~2013-10-04 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 17:31 tip-bot for Peter Zijlstra
2013-10-04 18:31 ` Adrian Hunter
2013-10-04 18:55   ` Peter Zijlstra [this message]
2013-10-06  9:10     ` Ingo Molnar
2013-10-07  9:33       ` Peter Zijlstra
2013-10-07 15:59         ` Peter Zijlstra
2013-10-07 17:22       ` H. Peter Anvin
2013-10-07 17:40         ` Peter Zijlstra
2013-10-07 18:30           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131004185539.GT15690@laptop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome