From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] [PATCH 2/5] revert: "blk-mq: blk-mq should free bios in pass through case"
Date: Sat, 5 Oct 2013 03:50:08 -0700 [thread overview]
Message-ID: <20131005105008.GA19022@infradead.org> (raw)
In-Reply-To: <524EFD55.4050701@cs.wisc.edu>
On Fri, Oct 04, 2013 at 12:39:33PM -0500, Mike Christie wrote:
> Sorry, messed up function name. I meant blk_end_request*.
>
> For blk_execute_rq_nowait/blk_execute_rq and normal request use, the
> lower levels free the bios as they are completed by one of the
> blk_finish_request* calls. The caller of of
> blk_execute_rq_nowait/blk_execute_rq does not have to worry about
> freeing bios. It just frees the request when it is done with it.
Are you talking about bios or requests? All these functions deal with
requests, so the talk of bios really confuses me.
That beeing said the old ones all require the caller to free the
request, and complicate that with the useless refcounting that my patch
3 removes. Take a look at the other patches how all the calling
conventions can be nicely unified.
next prev parent reply other threads:[~2013-10-05 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 13:49 [PATCH 0/5] blk-mq fixes and improvements Christoph Hellwig
2013-10-04 13:49 ` [PATCH 1/5] [PATCH 1/5] percpu_counter: fix irq restore in __percpu_counter_add Christoph Hellwig
2013-10-04 13:49 ` [PATCH 2/5] [PATCH 2/5] revert: "blk-mq: blk-mq should free bios in pass through case" Christoph Hellwig
2013-10-04 17:39 ` Mike Christie
2013-10-05 10:50 ` Christoph Hellwig [this message]
2013-10-05 20:20 ` Mike Christie
2013-10-06 15:02 ` Christoph Hellwig
2013-10-04 13:49 ` [PATCH 3/5] [PATCH 3/5] block: remove request ref_count Christoph Hellwig
2013-10-04 13:49 ` [PATCH 4/5] [PATCH 4/5] block: make blk_get/put_request work for blk-mq drivers Christoph Hellwig
2013-10-04 13:49 ` [PATCH 5/5] [PATCH 5/5] block: use blk-exec.c infrastructure for blk-mq Christoph Hellwig
2013-10-04 21:19 ` [PATCH 0/5] blk-mq fixes and improvements Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005105008.GA19022@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®