From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] sched/wait: wait_event*_timeout() needs ___wait_cond_timeout() too
Date: Mon, 7 Oct 2013 20:30:43 +0200 [thread overview]
Message-ID: <20131007183043.GA10969@redhat.com> (raw)
And another patch we already discussed.
wait_event_timeout(wq, true, 0) still returns 0, this doesn't look
right, and this doesn't match __wait_event_timeout(timeout => 0).
Sure, most probably nobody uses the constant timeout == 0, but this
can break the code which does something like
if (nonblock)
timeout = 0;
else
timeout = TIMEOUT;
success = wait_event_timeout(wq, CONDITION, timeout);
Oleg.
next reply other threads:[~2013-10-07 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 18:30 Oleg Nesterov [this message]
2013-10-07 18:31 ` [PATCH 1/1] " Oleg Nesterov
2013-10-17 16:49 ` [tip:sched/core] sched/wait: Add ___wait_cond_timeout() to wait_event*_timeout() too tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007183043.GA10969@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome