From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
joe@perches.com
Subject: Re: [PATCH 3/3] vsprintf: ignore %n again
Date: Tue, 8 Oct 2013 13:28:45 -0700 [thread overview]
Message-ID: <20131008132845.7e6c1c28f1c917f30ecb8dc5@linux-foundation.org> (raw)
In-Reply-To: <1381201011-4230-3-git-send-email-keescook@chromium.org>
On Mon, 7 Oct 2013 19:56:51 -0700 Kees Cook <keescook@chromium.org> wrote:
> This ignores %n in printf again, as was originally documented. Implementing
> %n poses a greater security risk than utility, so it should stay ignored.
> To help anyone attempting to use %n, a warning will be emitted if it is
> encountered.
>
> Based on earlier patch by Joe Perches.
Well this sucks. Nowhere in this patchset are we told what is the
alleged security risk with %n. There's even a runtime warning telling
people not to use it, but we've provided no way for them to find out
*why*.
Please send along suitable changelog text so I can fix this up.
A new checkpatch rule might be appropriate?
Two of these patches were acked-by:you. But you sent the patches, so I
changed these to Signed-off-by:, as per
Documentation/SubmittingPatches, section 12.
next prev parent reply other threads:[~2013-10-08 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 2:56 [PATCH 1/3] seq_file: Introduce seq_setwidth() and seq_pad() Kees Cook
2013-10-08 2:56 ` [PATCH 2/3] Remove "%n" usage from seq_file users Kees Cook
2013-10-08 2:56 ` [PATCH 3/3] vsprintf: ignore %n again Kees Cook
2013-10-08 20:28 ` Andrew Morton [this message]
2013-10-08 21:12 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008132845.7e6c1c28f1c917f30ecb8dc5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®