From: Benjamin LaHaise <bcrl@kvack.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [rfc] rework aio migrate pages to use aio fs
Date: Wed, 9 Oct 2013 09:55:09 -0400 [thread overview]
Message-ID: <20131009135509.GB16003@kvack.org> (raw)
In-Reply-To: <20131003025007.GC13318@ZenIV.linux.org.uk>
Hi Al,
On Thu, Oct 03, 2013 at 03:50:07AM +0100, Al Viro wrote:
...
> Another thing: I'd rather pull everything about setting the inode
> up (aops, size, etc.) in there.
>
> Anyway, could you take a look at the last couple of commits in
> vfs.git#for-bcrl? Commit message on the last one is an atrocity,
> of course...
Sorry for not replying sooner, I'd actually reviewed this last week but got
distracted before replying.
This looks much better in terms of the code that is specific to aio. I've
run the aio tests I wrote for the numa page migration test case, and they
look okay with your changes from vfs.git@for-bcrl. Please feel free to
add my Tested/Acked-by.
Tested-by: Benjamin LaHaise <bcrl@kvack.org>
Acked-by: Benjamin LaHaise <bcrl@kvack.org>
-ben
--
"Thought is the essence of where you are now."
prev parent reply other threads:[~2013-10-09 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:59 [GIT PULL] aio changes for 3.12 Benjamin LaHaise
2013-09-13 18:42 ` Al Viro
2013-09-17 14:18 ` [rfc] rework aio migrate pages to use aio fs Benjamin LaHaise
2013-10-03 2:22 ` Al Viro
2013-10-03 2:50 ` Al Viro
2013-10-09 13:55 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009135509.GB16003@kvack.org \
--to=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®