From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759Ab3JJKIN (ORCPT ); Thu, 10 Oct 2013 06:08:13 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:53642 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab3JJKIL (ORCPT ); Thu, 10 Oct 2013 06:08:11 -0400 Date: Thu, 10 Oct 2013 11:07:33 +0100 From: Will Deacon To: Chen Gang Cc: Martin Schwidefsky , Heiko Carstens , Russell King - ARM Linux , Catalin Marinas , "linux390@de.ibm.com" , "linux-s390@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] arm64: include: asm: atomic.h: use 'unsigned int' and 'atomic_t' instead of 'unsigned long' for atomic_clear_mask() Message-ID: <20131010100733.GH3817@mudshark.cambridge.arm.com> References: <52561137.3070608@asianux.com> <5256117A.4000009@asianux.com> <5256121A.9030504@asianux.com> <52561269.60900@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52561269.60900@asianux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2013 at 03:35:21AM +0100, Chen Gang wrote: > In current kernel wide source, for arm64, only s390 scsi drivers use > atomic_clear_mask(), now, s390 itself need use 'unsigned int' and > 'atomic_t', so need match s390's atomic_clear_mask(). > > > Signed-off-by: Chen Gang > --- > arch/arm64/include/asm/atomic.h | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h > index 8363644..58808fc 100644 > --- a/arch/arm64/include/asm/atomic.h > +++ b/arch/arm64/include/asm/atomic.h > @@ -126,16 +126,17 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new) > return oldval; > } > > -static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr) > +static inline void atomic_clear_mask(unsigned int mask, atomic_t *ptr) > { > - unsigned long tmp, tmp2; > + unsigned int tmp; Same comment here as for ARM; I think you want a signed int. Will