mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: ebiederm@xmission.com, hbabu@us.ibm.com, hpa@linux.intel.com,
	keescook@chromium.org, vgoyal@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: david.vrabel@citrix.com, jbeulich@suse.com, keir@xen.org,
	xen-devel@lists.xen.org
Subject: kexec: Clearing registers just before jumping into purgatory
Date: Fri, 11 Oct 2013 11:28:37 +0200	[thread overview]
Message-ID: <20131011092837.GZ3626@debian70-amd64.local.net-space.pl> (raw)

Hi,

Could you explain why do you clear all registers just before jumping
into purgatory (please look into arch/x86/kernel/relocate_kernel_64.S
for more details)? There is no any single word about that. I do not
count comment which states what is going on. purgatory on entry does
not assume any value in registers. Are you going to use that feature
for something in the future (e.g. to differentiate between callers
and/or Linux versions if it be needed)?

By the way, interestingly it is not done if preserve_context is in force.

Daniel

             reply	other threads:[~2013-10-11  9:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  9:28 Daniel Kiper [this message]
2013-10-11 10:08 ` Eric W. Biederman
2013-10-11 11:04   ` Daniel Kiper
2013-10-11 12:52     ` Vivek Goyal
2013-10-11 15:37       ` Matthew Garrett
2013-10-11 15:44         ` Vivek Goyal
2013-10-11 15:48           ` Matthew Garrett
2013-10-11 16:33             ` Richard Weinberger
2013-10-11 16:39               ` Matthew Garrett
2013-10-11 16:42                 ` Richard Weinberger
2013-10-11 16:44                   ` Matthew Garrett
2013-10-11 16:47                     ` Richard Weinberger
2013-10-11 16:55                       ` Matthew Garrett
2013-10-11 16:59                         ` Richard Weinberger
2013-10-11 17:01                           ` Matthew Garrett
2013-10-11 20:44                             ` Eric W. Biederman
2013-10-11 20:50                               ` Matthew Garrett
2013-10-11 16:53                     ` Vivek Goyal
2013-10-11 16:56                       ` Matthew Garrett
2013-10-11 22:15     ` Eric W. Biederman
2013-10-14 18:24       ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011092837.GZ3626@debian70-amd64.local.net-space.pl \
    --to=daniel.kiper@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ebiederm@xmission.com \
    --cc=hbabu@us.ibm.com \
    --cc=hpa@linux.intel.com \
    --cc=jbeulich@suse.com \
    --cc=keescook@chromium.org \
    --cc=keir@xen.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®