mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: yi zhang <yizhang.mrvl@gmail.com>
Cc: Yi Zhang <yizhang@marvell.com>,
	zhouqiao@marvell.com, zhangwm@marvell.com,
	linux-kernel@vger.kernel.org
Subject: Re: [Question]should we not ignore the masked interrupt in regmap?
Date: Sat, 12 Oct 2013 13:32:17 +0100	[thread overview]
Message-ID: <20131012123217.GK2443@sirena.org.uk> (raw)
In-Reply-To: <CAK=oMXetPxaQ-MeL9L9+182X220ivu2G5+i-42kqtAUjbfvg2w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

On Sat, Oct 12, 2013 at 11:14:27AM +0800, yi zhang wrote:

> 1) interrupt is triggered;
> 2) a thread disables it(then the mask bit is set);
> 3) _Then_ the interrupt thread is executed, it _ignore _ and doesn’t
> handle this interrupt;
>    because the interrupt is not ACKed, the interrupt status is not cleared;
> 4) in Marvell's PMIC, the interrupt line to SOC is always asserted,
> then irq storm happens;

This sounds like you need the workaround activated by init_ack_masked.
It's basically the hardware failing to implement masking sensibly - the
general expectation for a mask bit is that it will have no effect on the
actual state of the interrupt, only on if it's reported.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-10-12 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  3:14 yi zhang
2013-10-12 12:32 ` Mark Brown [this message]
2013-10-12 12:50   ` yi zhang
2013-10-12 15:40     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131012123217.GK2443@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yizhang.mrvl@gmail.com \
    --cc=yizhang@marvell.com \
    --cc=zhangwm@marvell.com \
    --cc=zhouqiao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®