From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932508Ab3JNUVM (ORCPT ); Mon, 14 Oct 2013 16:21:12 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42627 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932215Ab3JNUVK (ORCPT ); Mon, 14 Oct 2013 16:21:10 -0400 X-Originating-IP: 173.246.103.110 Date: Mon, 14 Oct 2013 13:20:53 -0700 From: Josh Triplett To: Joe Perches Cc: linux-kernel@vger.kernel.org, Nandini Hanumanthagowda , Greg Kroah-Hartman , Andy Whitcroft Subject: Re: [PATCH] checkpatch: Allow spaces before the ':' of a bitfield Message-ID: <20131014202053.GA4171@jtriplet-mobl1> References: <20131013121635.GA29395@nandinih-Inspiron-5521> <20131013153943.GA27861@kroah.com> <687af3bd-edc6-40cf-b994-0d0fdb7cd30d@googlegroups.com> <20131014173207.GE16517@jtriplet-mobl1> <1381773108.25528.22.camel@joe-AO722> <20131014180001.GA20139@jtriplet-mobl1> <1381773878.25528.24.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381773878.25528.24.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 14, 2013 at 11:04:38AM -0700, Joe Perches wrote: > On Mon, 2013-10-14 at 11:00 -0700, Josh Triplett wrote: > > On Mon, Oct 14, 2013 at 10:51:48AM -0700, Joe Perches wrote: > > > On Mon, 2013-10-14 at 10:32 -0700, Josh Triplett wrote: > > > > checkpatch warns about spaces both before and after the ':' separating a > > > > bitfield name from its width. However, many drivers do put space before > > > > the : to line up the widths, which makes the definition significantly > > > > more readable; checkpatch should not warn about that. Remove the > > > > warning for space before the ':' of a bitfield. > > > > > > There are a _bunch_ of different styles used for > > > alignment of bitfields. > > > > > > $ grep -rPh --include=*.[ch] \ > > > '(?:unsigned\s+|signed\s+|)(char|short|long|long\s+long|\w+_t|(?:__|)(?:u|s)(?:8|16|32|64))\s+\w+\s*:\s*\d+\s*(?:,|;)' * > > > > > > spaces before colon > > > spaces after colon > > > aligned on bitfield size > > > > > > I'd just as soon make it a --strict check. > > > > I'd be fine with removing the check entirely, or making it --strict; > > however, even for --strict mode I'd suggest applying this patch, as I > > don't think checkpatch should ever prohibit spaces before the ':'. > > Maybe something like that patch, but spaces probably > should be prohibited after the : in a bitfield either. > > This style is pretty common > > u32 dma_address0 :30; > u32 dma_0No_update : 1; > u32 dma_0start : 1; > u32 dma_addr_size :24; > u32 DMA_maxpackets : 8; I'm fine with just dropping the check entirely; want a patch for that instead? It's a much simpler patch. - Josh Triplett