mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"Wang, Xiaoming" <xiaoming.wang@intel.com>,
	"Li, Zhuangzhi" <zhuangzhi.li@intel.com>,
	"Liu, Chuansheng" <chuansheng.liu@intel.com>
Subject: Re: [PATCH] x86: Remove WARN_ON(in_nmi()) from vmalloc_fault
Date: Wed, 16 Oct 2013 09:14:37 -0400	[thread overview]
Message-ID: <20131016091437.146cb9d4@gandalf.local.home> (raw)
In-Reply-To: <20131016130856.GE12773@localhost.localdomain>

On Wed, 16 Oct 2013 15:08:57 +0200
Frederic Weisbecker <fweisbec@gmail.com> wrote:


> Faults can call rcu_user_exit() / rcu_user_enter(). This is not supposed to happen
> between rcu_nmi_enter() and rcu_nmi_exit(). rdtp->dynticks would be incremented in the
> wrong way.
> 
> Ah but we have an in_interrupt() check in context_tracking_user_enter() that protects
> us against that.

I will say that we should probably warn if it's any fault other than a
vmalloc fault. A vmalloc fault should only happen in kernel space, and
should not be happening from user code.

> 
> > 
> > > 
> > > So I hope we can think about something else for the long term.
> > 
> > I still don't understand what's wrong with it. As long as the faulting
> > code does not grab any locks there shouldn't be anything wrong with
> > faulting in NMI. For vmalloc, it is just updating page tables.
> 
> NMI code is written with the idea that it can't be interrupted. May be that
> paranoia (again), you know. And I can't point you any problem in practice.
> I just think that allowing such a thing is asking for troubles.

The WARN_ON() that I removed is from vmalloc fault. I don't see an
issue with NMIs faulting via vmalloc. For any other page fault, sure, I
would be concerned about it. But what's wrong with an NMI running
module code?

> 
> But I'm ok with your patch, it fixes a real bug and as long as we don't have
> a better solution, we should keep that.
> 
> BTW, does faulting in NMIs re-enable NMIs?

Yes, but we now have code to handle that :-)

-- Steve

  reply	other threads:[~2013-10-16 13:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15 20:39 Steven Rostedt
2013-10-16  6:11 ` Ingo Molnar
2013-10-16 12:42   ` Steven Rostedt
2013-10-16 12:51     ` Ingo Molnar
2013-10-16 13:01       ` Borislav Petkov
2013-10-16 13:03       ` Steven Rostedt
2013-10-17  0:29       ` Liu, Chuansheng
2013-10-16 11:40 ` Frederic Weisbecker
2013-10-16 12:45   ` Steven Rostedt
2013-10-16 13:08     ` Frederic Weisbecker
2013-10-16 13:14       ` Steven Rostedt [this message]
2013-10-16 13:28         ` Frederic Weisbecker
2013-10-16 13:37           ` Steven Rostedt
2013-10-16 19:39             ` Paul E. McKenney
2013-10-16 19:36       ` Paul E. McKenney
2013-10-16 19:57         ` Steven Rostedt
2013-10-18 11:54           ` Paul E. McKenney
2013-10-17 13:59         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131016091437.146cb9d4@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=chuansheng.liu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xiaoming.wang@intel.com \
    --cc=zhuangzhi.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®