From: Matt Fleming <matt@console-pimps.org>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
matt.fleming@intel.com, tony.luck@intel.com,
tomoki.sekiyama@hds.com, dle-develop@lists.sourceforge.net
Subject: Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed
Date: Thu, 17 Oct 2013 14:18:21 +0100 [thread overview]
Message-ID: <20131017131821.GH10834@console-pimps.org> (raw)
In-Reply-To: <52584373.3010202@hds.com>
On Fri, 11 Oct, at 02:29:07PM, Seiji Aguchi wrote:
> Change from v2:
> - Move dynamic memory allocation to efi_pstore_read() before holding
> efivars->lock to protect entry->var.Data.
> - Access to entry->scanning while holding efivars->lock.
> - Move a comment about a returned value from efi_pstore_read_func() to
> efi_pstore_read() because "size < 0" case may happen in efi_pstore_read().
It seems to me that because you're no longer dropping __efivars->lock
when reading from the EFI variable store, you actually don't need all
the ->scanning and ->deleting logic because anything that sets those
flags runs to completion while holding the lock.
Can't the patch be simplified to just allocating data.buf at the
beginning of efi_pstore_read()? Also, it would be a good idea to
introduce a #define for the 1024 magic number, e.g.
#define EFIVARS_DATA_SIZE_MAX 1024
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-17 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:29 Seiji Aguchi
2013-10-17 5:54 ` Madper Xie
2013-10-17 13:07 ` Seiji Aguchi
2013-10-17 14:30 ` Madper Xie
2013-10-17 15:07 ` Madper Xie
2013-10-17 15:11 ` Seiji Aguchi
2013-10-17 13:18 ` Matt Fleming [this message]
2013-10-18 22:30 ` Seiji Aguchi
2013-10-30 14:35 ` Matt Fleming
2013-10-30 19:19 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017131821.GH10834@console-pimps.org \
--to=matt@console-pimps.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=seiji.aguchi@hds.com \
--cc=tomoki.sekiyama@hds.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®