mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	peterz@infradead.org, dsahern@gmail.com, jolsa@redhat.com,
	ak@linux.intel.com
Subject: Re: [PATCH v3] perf: disable PERF_RECORD_MMAP2 support
Date: Thu, 17 Oct 2013 16:26:30 -0300	[thread overview]
Message-ID: <20131017192630.GB6443@infradead.org> (raw)
In-Reply-To: <20131017173215.GA8820@quad>

Em Thu, Oct 17, 2013 at 07:32:15PM +0200, Stephane Eranian escreveu:
> 
> For now, we disable the extended MMAP record support (MMAP2).
> We have identified cases where it would not report the correct
> mapping information, clone(VM_CLONE) but with separate pids.
> We will revisit the support once we find a solution for this case.
> 
> The patch changes the kernel to return EINVAL if attr->mmap2
> is set. The patch also modifies the perf tool to use regular PERF_RECORD_MMAP
> for synthetic events and it also prevents the tool from requesting attr->mmap2
> mode because the kernel would reject it.
> 
> The support will be revisited once the kenrel interface is updated.
> 
> In V2, we reduce the patch to the strict minimum.
> In V3, we avoid calling perf_event_open() with mmap2 set because we
> know it will fail and require fallback retry.

Again it applied, but with some fuzz, which branch did you coded this
against? Testing...

[acme@zoo linux]$ patch -p1 < /wb/1
patching file kernel/events/core.c
Hunk #1 succeeded at 6767 (offset -6 lines).
patching file tools/perf/util/event.c
patching file tools/perf/util/evsel.c
Hunk #1 succeeded at 678 with fuzz 1.
[acme@zoo linux]$ 

- Arnaldo

  reply	other threads:[~2013-10-17 19:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 17:32 Stephane Eranian
2013-10-17 19:26 ` Arnaldo Carvalho de Melo [this message]
2013-10-20 19:31 ` [tip:perf/urgent] perf: Disable " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017192630.GB6443@infradead.org \
    --to=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®