mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: kernel-br@googlegroups.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 1/2] tracing: creates 'tracing_is_disabled()'
Date: Fri, 18 Oct 2013 20:09:51 -0400	[thread overview]
Message-ID: <20131018200951.3636bcf7@gandalf.local.home> (raw)
In-Reply-To: <1382129982-9668-1-git-send-email-geyslan@gmail.com>

On Fri, 18 Oct 2013 17:59:41 -0300
"Geyslan G. Bem" <geyslan@gmail.com> wrote:

> This patch creates the function 'tracing_is_disabled ", which
> can be used outside trace.c.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  kernel/trace/trace.c | 5 +++++
>  kernel/trace/trace.h | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 7974ba2..a120a73 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2964,6 +2964,11 @@ int tracing_open_generic(struct inode *inode, struct file *filp)
>  	return 0;
>  }
>  
> +inline bool tracing_is_disabled(void)

Nuke the "inline". Gcc and other compilers are smart enough to know to
inline it on a -O2, that we don't need it. Especially, when it's used
in another file.

-- Steve

> +{
> +	return (tracing_disabled) ? true: false;
> +}
> +
>  /*
>   * Open and update trace_array ref count.
>   * Must have the current trace_array passed to it.
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h

  parent reply	other threads:[~2013-10-19  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18 20:59 Geyslan G. Bem
2013-10-18 20:59 ` [PATCH 2/2] tracing: fix referencing after memory freeing and refactors code Geyslan G. Bem
2013-11-06 16:17   ` Steven Rostedt
2013-11-06 19:08     ` Geyslan Gregório Bem
2013-10-19  0:09 ` Steven Rostedt [this message]
2013-10-19  0:22   ` [PATCH 1/2] tracing: creates 'tracing_is_disabled()' Geyslan Gregório Bem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131018200951.3636bcf7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=geyslan@gmail.com \
    --cc=kernel-br@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®