From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Alireza Haghdoost <alireza@cs.umn.edu>,
linux-kernel@vger.kernel.org,
Jerry Fredin <jerry.fredin@netapp.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block/aio: Enable sysfs nomerge control for I/O requests in the plug list
Date: Wed, 23 Oct 2013 17:10:38 +0100 [thread overview]
Message-ID: <20131023161038.GI14598@kernel.dk> (raw)
In-Reply-To: <x49txg8x9ro.fsf@segfault.boston.devel.redhat.com>
On Wed, Oct 23 2013, Jeff Moyer wrote:
> Alireza Haghdoost <alireza@cs.umn.edu> writes:
>
> > This patch enables the sysfs to control I/O request merge
> > functionality in the plug list. While this control has been
> > implemented for the request queue, it was dismissed in the plug list.
> > Therefore, block layer merges requests together (or attempt to merge)
> > even if the merge capability was disable using sysfs nomerge parameter
> > value 2.
>
> Yeah, this looks like an oversight. Your mailer really munged up the
> patch, though. You should fix that and resend (unless Jens just fixes
> it up manually). Also, please specify the -p option to diff or just use
> git diff.
I fixed it up, changed the style slightly as well (no point in reading
and checking the plug first). This is what I queued up:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=dfc302d833c46f40b5f775099da00bb0cf0e81ad
--
Jens Axboe
prev parent reply other threads:[~2013-10-23 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 23:54 Alireza Haghdoost
2013-10-23 15:54 ` Jeff Moyer
2013-10-23 16:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023161038.GI14598@kernel.dk \
--to=axboe@kernel.dk \
--cc=alireza@cs.umn.edu \
--cc=jerry.fredin@netapp.com \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome