mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Michal Marek <mmarek@suse.cz>,
	haver@linux.vnet.ibm.com, Frank Haverkamp <haver@vnet.ibm.com>,
	linux-kernel@vger.kernel.org, arnd@arndb.de,
	cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	utz.bacher@de.ibm.com, jsvogt@de.ibm.com, MIJUNG@de.ibm.com,
	cascardo@linux.vnet.ibm.com, michae@jasper.es
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
Date: Wed, 23 Oct 2013 11:15:25 -0700	[thread overview]
Message-ID: <20131023181525.GB23728@roeck-us.net> (raw)
In-Reply-To: <20131023152250.GA5224@kroah.com>

On Wed, Oct 23, 2013 at 04:22:50PM +0100, Greg KH wrote:
> On Wed, Oct 23, 2013 at 05:06:41PM +0200, Michal Marek wrote:
> > On 23.10.2013 16:14, Frank Haverkamp wrote:
> > > of course you are right. Let me try again.
> > > 
> > > I hope this looks better now:
> > > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n",
> > > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx);
> > > ...
> 
> Also, _no_ driver should ever be doing this type of "hey, look at me,
> I'm now loaded!" type syslog spam anymore.  It's pointless, and should
> be abolished where ever possible.  That's one reason we have moved to
> the driver init type functions that make this impossible to do, and if
> possible, I recommend doing that here as well.
> 
I agree. Do we have that as a general policy written down somewhere ?
That would help in reviews with authors insisting that they absolutely
want such messages. 

Thanks,
Guenter

  reply	other threads:[~2013-10-23 18:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  8:28 [RFC] " Frank Haverkamp
2013-07-25  8:28 ` Frank Haverkamp
2013-07-25 13:21   ` Michal Marek
2013-07-26 12:20     ` Frank Haverkamp
2013-07-26 12:29       ` Michal Marek
2013-10-23 13:15     ` Frank Haverkamp
2013-10-23 13:40       ` Michal Marek
2013-10-23 14:14         ` Frank Haverkamp
2013-10-23 15:06           ` Michal Marek
2013-10-23 15:22             ` Greg KH
2013-10-23 18:15               ` Guenter Roeck [this message]
2013-10-24  9:56                 ` Greg KH
2013-10-23 14:54       ` Greg KH
2013-10-23 18:27   ` Bjorn Helgaas
2013-10-25  7:56     ` Frank Haverkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131023181525.GB23728@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=MIJUNG@de.ibm.com \
    --cc=arnd@arndb.de \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=cody@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haver@linux.vnet.ibm.com \
    --cc=haver@vnet.ibm.com \
    --cc=jsvogt@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michae@jasper.es \
    --cc=mmarek@suse.cz \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®