From: Tejun Heo <tj@kernel.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Lothar Waßmann" <LW@karo-electronics.de>
Subject: Re: [PATCH next] sysfs: fix sysfs_write_file for bin file
Date: Thu, 24 Oct 2013 11:31:38 +0100 [thread overview]
Message-ID: <20131024103138.GA13159@mtj.dyndns.org> (raw)
In-Reply-To: <1382535893-20543-1-git-send-email-ming.lei@canonical.com>
On Wed, Oct 23, 2013 at 09:44:53PM +0800, Ming Lei wrote:
> Before patch(sysfs: prepare path write for unified regular / bin
> file handling), when size of bin file is zero, writting still can
> continue, but this patch changes the behaviour.
>
> The worse thing is that firmware loader is broken by this patch,
> and user space application can't write to firmware bin file any more
> because both firmware loader and drivers can't know at advance how
> large the firmware file is and have to set its initialized size as
> zero.
>
> This patch fixes the problem and keeps behaviour of writting to bin
> as before.
>
> Reported-and-tested-by: Lothar Waßmann <LW@karo-electronics.de>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
Oops, sorry about missing that.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
--
tejun
prev parent reply other threads:[~2013-10-24 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 13:44 Ming Lei
2013-10-24 10:31 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024103138.GA13159@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=LW@karo-electronics.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®