mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Mazur <krzysiek@podlesie.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: usbatm: printk_ratelimit() always called in the atm_rldbg()
Date: Sat, 26 Oct 2013 15:29:56 +0200	[thread overview]
Message-ID: <20131026132955.GA9251@shrek.podlesie.net> (raw)

Hi,

commit 2d6401cf4ca3861692a4779745e0049cac769d10
("USB: usbatm: move the atm_dbg() call to use dynamic debug")
changed the atm_rldbg() to:

#define atm_rldbg(instance, format, arg...)		\
	if (printk_ratelimit())				\
		atm_dbg(instance , format , ## arg)

and now printk_ratelimit() is always called even when debugging is
disabled and a lot of "callbacks suppressed" messages are printed
by the printk_ratelimit():

[...]
usbatm_rx_process: 4977 callbacks suppressed
usbatm_extract_one_cell: 2920 callbacks suppressed
[...]


I'm not sure how to fix that, maybe we need dynamic_pr_debug_ratelimit()?

Krzysiek

             reply	other threads:[~2013-10-26 13:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26 13:29 Krzysztof Mazur [this message]
2013-10-26 17:37 ` Greg Kroah-Hartman
2013-10-26 18:52   ` [PATCH] printk: pr_debug_ratelimited: check state first to reduce "callbacks suppressed" messages Joe Perches
2013-10-26 19:01     ` Greg Kroah-Hartman
2013-10-26 19:51       ` Joe Perches
2013-10-27  3:41       ` [PATCH V2] " Joe Perches
2013-10-27 10:33         ` Krzysztof Mazur
2013-10-26 18:55   ` [PATCH] atmusb: Fix dynamic_debug macros Joe Perches
2013-10-26 19:28     ` Joe Perches
2013-10-26 20:02       ` Krzysztof Mazur
2013-10-27  3:49       ` [PATCH V2] usbatm: Fix dynamic_debug / ratelimited atm_dbg and atm_rldbg macros Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131026132955.GA9251@shrek.podlesie.net \
    --to=krzysiek@podlesie.net \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®