mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Mazur <krzysiek@podlesie.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH] DYNAMIC_DEBUG: use select DEBUG_FS instead of depends on
Date: Sun, 27 Oct 2013 09:01:51 +0100	[thread overview]
Message-ID: <20131027080151.GA26131@shrek.podlesie.net> (raw)
In-Reply-To: <20131027033000.GB32210@kroah.com>

On Sat, Oct 26, 2013 at 08:30:00PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Oct 26, 2013 at 10:58:13PM +0200, Krzysztof Mazur wrote:
> > Depending on options that are configured later makes them hard
> > to enable unless the user knows that he must go backwards.
> 
> Really?  We've had this for well over 2 years, people are confused about
> this?
> 
> Where?

The v3.10 is ok - CONFIG_DYNAMIC_DEBUG is after CONFIG_DEBUG_FS.

Maybe it's just me, because on my config I have CONFIG_DEBUG_FS=y,
and on the system I was testing usbatm I had CONFIG_DEBUG_FS=n.

BTW, on x86_64 to disable CONFIG_DEBUG_FS you need to disable
CONFIG_AMD_IOMMU_STATS, which is enabled by default in the
x86_64_defconfig (I think that CONFIG_AMD_IOMMU_STATS=n it's
a better default). If you enable CONFIG_DEBUG_KERNEL you
need to disable CONFIG_FTRACE which is enabled by default.
So a lot of users will have CONFIG_DEBUG_FS already selected.

Thanks,
Krzysiek

  reply	other threads:[~2013-10-27  8:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26 20:58 Krzysztof Mazur
2013-10-27  3:30 ` Greg Kroah-Hartman
2013-10-27  8:01   ` Krzysztof Mazur [this message]
2013-10-27 14:38     ` Randy Dunlap
2013-10-27 15:57       ` Krzysztof Mazur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131027080151.GA26131@shrek.podlesie.net \
    --to=krzysiek@podlesie.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®