From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Johannes Löthberg" <johannes@kyriasis.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Andres More <more.andres@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c
Date: Sun, 27 Oct 2013 06:53:42 -0700 [thread overview]
Message-ID: <20131027135342.GA17564@kroah.com> (raw)
In-Reply-To: <1382592407-26728-3-git-send-email-johannes@kyriasis.com>
On Thu, Oct 24, 2013 at 07:26:47AM +0200, Johannes Löthberg wrote:
> This patch fixes a code indentation error found by checkpatch.pl
> where a line was indented with spaces instead of tabs
>
> Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
> ---
> drivers/staging/vt6656/power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
> index 3002061..a14a2bf 100644
> --- a/drivers/staging/vt6656/power.c
> +++ b/drivers/staging/vt6656/power.c
> @@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
> + sizeof(struct vnt_tx_mgmt));
>
> flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
> - WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
> + WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
No, indent this line properly using tabs to where the spaces were,
that's the correct location.
greg k-h
prev parent reply other threads:[~2013-10-27 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 5:26 [PATCH 0/2] Staging: vt6656: fix two coding style issues Johannes Löthberg
2013-10-24 5:26 ` [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c Johannes Löthberg
2013-10-24 5:26 ` [PATCH 2/2] Staging: vt6656: fix code indenting error " Johannes Löthberg
2013-10-27 13:53 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027135342.GA17564@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=johannes@kyriasis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=more.andres@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome