From: David Miller <davem@davemloft.net>
To: tdmackey@booleanhaiku.com
Cc: mchan@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()
Date: Tue, 29 Oct 2013 22:42:27 -0400 (EDT) [thread overview]
Message-ID: <20131029.224227.1700872646112764527.davem@davemloft.net> (raw)
In-Reply-To: <1383084998-22673-1-git-send-email-tdmackey@booleanhaiku.com>
From: David Mackey <tdmackey@booleanhaiku.com>
Date: Tue, 29 Oct 2013 15:16:38 -0700
> Using dev_kfree_skb_any() will resolve the below issue when a
> netconsole message is transmitted in an irq.
...
> Signed-off-by: David Mackey <tdmackey@booleanhaiku.com>
This is absolutely not the correct fix.
The netpoll facility must invoke ->poll() in an environment which
is compatible, locking and interrupt/soft-interrupt wise, as that
in which it is normally called.
Therefore, bnx2_tx_int(), which is invoked from the driver's ->poll()
method, should not need to use dev_kfree_skb_any(). The real problem
is somewhere else.
next prev parent reply other threads:[~2013-10-30 2:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 22:16 David Mackey
2013-10-30 2:42 ` David Miller [this message]
2013-10-30 3:50 ` Cong Wang
2013-10-30 6:40 ` David Miller
2013-10-30 19:23 ` Cong Wang
2013-10-30 21:32 ` David Miller
2013-10-30 22:01 ` Cong Wang
2013-10-31 4:26 ` David Miller
[not found] ` <CAM_iQpXPrEj619=PRaKN4PxgOoEB96U0mLFS65AzXOezSWvhxQ@mail.gmail.com>
2013-11-01 22:01 ` David Miller
2013-11-01 23:34 ` Ben Hutchings
2013-11-02 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.224227.1700872646112764527.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=tdmackey@booleanhaiku.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®