From: Andrew Morton <akpm@linux-foundation.org>
To: Nicolin Chen <b42378@freescale.com>
Cc: <joe@perches.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] lib/genalloc: add a helper function for DMA buffer allocation
Date: Thu, 31 Oct 2013 14:26:19 -0700 [thread overview]
Message-ID: <20131031142619.d7aed35fe536f5a177012d27@linux-foundation.org> (raw)
In-Reply-To: <1383210967-25804-1-git-send-email-b42378@freescale.com>
On Thu, 31 Oct 2013 17:16:07 +0800 Nicolin Chen <b42378@freescale.com> wrote:
> When using pool space for DMA buffer, there might be duplicated calling
> of gen_pool_alloc() and gen_pool_virt_to_phys() in each implementation.
>
> Thus it's better to add a simple helper function, a compatible one to
> the common dma_alloc_coherent(), to save some code.
>
Well OK, but this new function doesn't have any callers. So it
increases kernel size and is untestable.
Do you have any conversion patches which we can merge to address these
problems?
next prev parent reply other threads:[~2013-10-31 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:16 Nicolin Chen
2013-10-31 21:26 ` Andrew Morton [this message]
2013-11-01 5:27 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031142619.d7aed35fe536f5a177012d27@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=b42378@freescale.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®