From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, zheng.z.yan@intel.com,
bp@alien8.de, maria.n.dimakopoulou@gmail.com
Subject: Re: [PATCH v4 3/4] perf/x86: add Intel RAPL PMU support
Date: Thu, 31 Oct 2013 16:14:23 +0100 [thread overview]
Message-ID: <20131031151423.GX19466@laptop.lan> (raw)
In-Reply-To: <1383231582-15856-4-git-send-email-eranian@google.com>
On Thu, Oct 31, 2013 at 03:59:41PM +0100, Stephane Eranian wrote:
> +/*
> + * we compute in 0.23 nJ increments regardless of MSR
We don't in fact use 0.23 nJ, we use 2^-32 J.
> + */
> +EVENT_ATTR_STR(energy-cores.scale, rapl_cores_scale, "2.3e-10");
> +EVENT_ATTR_STR(energy-pkg.scale, rapl_pkg_scale, "2.3e-10");
> +EVENT_ATTR_STR(energy-ram.scale, rapl_ram_scale, "2.3e-10");
Am I weird for proposing we use:
"2.3283064365386962890625e-10"
instead? Its not like anybody needs to go type this by hand.
next prev parent reply other threads:[~2013-10-31 15:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 14:59 [PATCH v4 0/4] " Stephane Eranian
2013-10-31 14:59 ` [PATCH v4 1/4] perf: add active_entry list head to struct perf_event Stephane Eranian
2013-10-31 14:59 ` [PATCH v4 2/4] perf stat: add event unit and scale support Stephane Eranian
2013-11-01 10:57 ` Jiri Olsa
2013-11-04 14:47 ` Stephane Eranian
2013-11-04 14:51 ` Jiri Olsa
2013-11-05 13:34 ` Stephane Eranian
2013-11-05 14:00 ` Jiri Olsa
2013-11-05 14:04 ` Stephane Eranian
2013-11-05 14:16 ` Andi Kleen
2013-11-05 14:17 ` Stephane Eranian
2013-11-05 15:03 ` Stephane Eranian
2013-10-31 14:59 ` [PATCH v4 3/4] perf/x86: add Intel RAPL PMU support Stephane Eranian
2013-10-31 15:14 ` Peter Zijlstra [this message]
2013-10-31 14:59 ` [PATCH v4 4/4] perf,x86: add RAPL hrtimer support Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031151423.GX19466@laptop.lan \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maria.n.dimakopoulou@gmail.com \
--cc=mingo@elte.hu \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®