mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Michael Hudson-Doyle <michael.hudson@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jean Pihet <jean.pihet@linaro.org>
Subject: Re: [PATCH] perf tools: Remove cast of non-varadic function to varadic
Date: Thu, 31 Oct 2013 20:06:16 +0000	[thread overview]
Message-ID: <20131031200616.GC31516@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <877gctxlry.fsf@canonical.com>

Hi Michael,

On Thu, Oct 31, 2013 at 07:50:25PM +0000, Michael Hudson-Doyle wrote:
> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of
> percent_color_snprintf to a function pointer type with varargs.  Change
> percent_color_snprintf to be varadic and remove the cast.

nit: s/varadic/variadic/

> The symptom of this was all percentages being reported as 0.00% in perf
> report --stdio output on armhf.

  Acked-by: Will Deacon <will.deacon@arm.com>

Probably worth CCing stable too.

Will

  reply	other threads:[~2013-10-31 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 19:50 Michael Hudson-Doyle
2013-10-31 20:06 ` Will Deacon [this message]
2013-10-31 20:09 ` Arnaldo Carvalho de Melo
2013-10-31 21:19   ` Michael Hudson-Doyle
2013-11-01  7:51   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031200616.GC31516@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=acme@redhat.com \
    --cc=jean.pihet@linaro.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hudson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®