From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752438Ab3KAMvE (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Nov 2013 08:51:04 -0400
Received: from arkanian.console-pimps.org ([212.110.184.194]:57759 "EHLO
	arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750762Ab3KAMvC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Nov 2013 08:51:02 -0400
Date: Fri, 1 Nov 2013 12:50:57 +0000
From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>, Linux EFI <linux-efi@vger.kernel.org>,
        Borislav Petkov <bp@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>, Vivek Goyal <vgoyal@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>
Subject: Re: [PATCH 10/11] EFI: Runtime services virtual mapping
Message-ID: <20131101125057.GA21688@console-pimps.org>
References: <1383236709-19716-1-git-send-email-bp@alien8.de>
 <1383236709-19716-11-git-send-email-bp@alien8.de>
 <20131101032551.GC4378@dhcp-16-126.nay.redhat.com>
 <20131101033508.GA13527@dhcp-16-126.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131101033508.GA13527@dhcp-16-126.nay.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 01 Nov, at 11:35:08AM, Dave Young wrote:
> > The conflict is caused by missing one commit in matt's efi next tree:
> > 
> > commit 700870119f49084da004ab588ea2b799689efaf7
> > Author: Josh Boyer <jwboyer@redhat.com>
> > Date:   Thu Apr 18 07:51:34 2013 -0700
> > 
> >     x86, efi: Don't map Boot Services on i386
> >     
> >     Add patch to fix 32bit EFI service mapping (rhbz 726701)
> >     
> >     Multiple people are reporting hitting the following WARNING on i386,
> >     
> >       WARNING: at arch/x86/mm/ioremap.c:102 __ioremap_caller+0x3d3/0x440()
> >       Modules linked in:
> >       Pid: 0, comm: swapper Not tainted 3.9.0-rc7+ #95
> 
> Rethinking about above commit, it is actually a workaround for
> mapping boot service, I suspect the problem connect to the off-by-one
> problem in boot service reserve function. Matt, idea?

No, it's not the same problem. And just to make absolutely sure I
reverted the above commit and applied your patch, but I still see the
WARN_ON() described above.

-- 
Matt Fleming, Intel Open Source Technology Center