From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 3/3] perf tools: Check maximum frequency rate for record/top
Date: Mon, 4 Nov 2013 16:32:16 +0100 [thread overview]
Message-ID: <20131104153216.GC2805@krava.brq.redhat.com> (raw)
In-Reply-To: <5277BA84.1090208@gmail.com>
On Mon, Nov 04, 2013 at 08:17:24AM -0700, David Ahern wrote:
> On 11/4/13, 4:06 AM, Jiri Olsa wrote:
> >Adding the check for maximum allowed frequency rate
> >defined in following file:
> > /proc/sys/kernel/perf_event_max_sample_rate
> >
> >When we cross the maximum value we fail and display
> >detailed error message with advise.
>
> perf commands should automatically adjust the default frequency too.
> If the user did not specify a frequency then this message is going
> to be confusing.
ok, I'll add that check and probably some warning
if we are force to go below the default rate.
>
> Though the algorithm that keeps lowering the rate should be tweaked as well.
yea.. I was thinking putting the max rate back up after
some sane period
or/plus having 'echo 0 > /proc/sys/kernel/perf_event_max_sample_rate' to
disable it completely
jirka
next prev parent reply other threads:[~2013-11-04 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 11:06 [PATCH 0/3] perf tools: Add perf_event_max_sample_rate freq check Jiri Olsa
2013-11-04 11:06 ` [PATCH 1/3] perf tools: Factor sysfs code into generic fs object Jiri Olsa
2013-11-05 12:48 ` Arnaldo Carvalho de Melo
2013-11-05 13:07 ` Jiri Olsa
2013-11-05 14:55 ` Arnaldo Carvalho de Melo
2013-11-04 11:06 ` [PATCH 2/3] perf tools: Add procfs support into " Jiri Olsa
2013-11-04 11:06 ` [PATCH 3/3] perf tools: Check maximum frequency rate for record/top Jiri Olsa
2013-11-04 15:17 ` David Ahern
2013-11-04 15:32 ` Jiri Olsa [this message]
2013-11-04 17:56 ` Arnaldo Carvalho de Melo
2013-11-04 19:01 ` [PATCH 0/3] perf tools: Add perf_event_max_sample_rate freq check Jiri Olsa
2013-11-05 14:14 [PATCHv2 " Jiri Olsa
2013-11-05 14:14 ` [PATCH 3/3] perf tools: Check maximum frequency rate for record/top Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131104153216.GC2805@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome