From: David Sterba <dsterba@suse.cz>
To: Aldo Iljazi <mail@aldo.io>
Cc: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BTRFS: fixed coding style issues
Date: Tue, 5 Nov 2013 10:43:54 +0100 [thread overview]
Message-ID: <20131105094354.GD16999@twin.jikos.cz> (raw)
In-Reply-To: <1383634921-4271-1-git-send-email-mail@aldo.io>
On Tue, Nov 05, 2013 at 09:02:01AM +0200, Aldo Iljazi wrote:
> Line 4989: Inserted a space after the comma.
> Lines 7986 and 8274: Inserted a space before the open parenthesis.
Hm, I don't know why my message from yesterday did not make it to the
list, but I'm objecting against flow of such changes that are not always
actual changes (replacing spaces by tabs). We don't really need them at
this point of development phase of btrfs.
The style issues should be fixed when a patch is being merged, doing it
afterwards increases patch history and makes digging in history
unnecessarily tedious.
There are lots of opportunities to do actual code cleanup, whitespaces
are just noise.
david
prev parent reply other threads:[~2013-11-12 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 7:02 Aldo Iljazi
2013-11-05 9:43 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105094354.GD16999@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=chris.mason@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@aldo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®