From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tracing: Update event filters for multibuffer
Date: Tue, 5 Nov 2013 17:27:45 -0500 [thread overview]
Message-ID: <20131105172745.2ebbd6ba@gandalf.local.home> (raw)
In-Reply-To: <f16e9ce4270c62f46b2e966119225e1c3cca7e60.1382620672.git.tom.zanussi@linux.intel.com>
On Thu, 24 Oct 2013 08:34:17 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> @@ -1577,6 +1577,7 @@ static void event_remove(struct ftrace_event_call *call)
> if (file->event_call != call)
> continue;
> ftrace_event_enable_disable(file, 0);
> + destroy_preds(file);
> /*
> * The do_for_each_event_file() is
> * a double loop. After finding the call for this
> @@ -1700,7 +1701,7 @@ static void __trace_remove_event_call(struct ftrace_event_call *call)
> {
> event_remove(call);
> trace_destroy_fields(call);
> - destroy_preds(call);
> + destroy_call_preds(call);
A small nit, but I don't believe we need this anymore.
First, what event that requires a call filter can be removed?
Second, if one could be removed, the previous call to "event_remove"
would remove the filter for us, as destroy_preds(file) calls
destroy_call_preds() if the USE_CALL_FILTER flag is set.
I'll keep it in for now, but may remove it later.
-- Steve
> }
>
next prev parent reply other threads:[~2013-11-05 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 13:34 [PATCH 0/3] tracing: add support for multibuffer event filters Tom Zanussi
2013-10-24 13:34 ` [PATCH 1/3] tracing: Update event filters for multibuffer Tom Zanussi
2013-11-05 22:27 ` Steven Rostedt [this message]
2013-11-06 5:32 ` Tom Zanussi
2013-10-24 13:34 ` [PATCH 2/3] tracing: Make register/unregister_ftrace_command __init Tom Zanussi
2013-10-24 13:34 ` [PATCH 3/3] tracing: Add support for SOFT_DISABLE to syscall events Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105172745.2ebbd6ba@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®