mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Cc: kernel@pengutronix.de, linux@arm.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Date: Wed, 6 Nov 2013 09:47:43 +0100	[thread overview]
Message-ID: <20131106084743.GV14892@pengutronix.de> (raw)
In-Reply-To: <1383724365-15196-1-git-send-email-duanj.fnst@cn.fujitsu.com>

On Wed, Nov 06, 2013 at 03:52:45PM +0800, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

> ---
>  arch/arm/mach-imx/mx31moboard-smartbot.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mx31moboard-smartbot.c b/arch/arm/mach-imx/mx31moboard-smartbot.c
> index 04ae45d..af6550e 100644
> --- a/arch/arm/mach-imx/mx31moboard-smartbot.c
> +++ b/arch/arm/mach-imx/mx31moboard-smartbot.c
> @@ -141,10 +141,7 @@ static int __init smartbot_otg_host_init(void)
>  		return -ENODEV;
>  
>  	pdev = imx31_add_mxc_ehci_otg(&otg_host_pdata);
> -	if (IS_ERR(pdev))
> -		return PTR_ERR(pdev);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(pdev);
>  }
>  #else
>  static inline int smartbot_otg_host_init(void) { return 0; }
> -- 
> 1.8.3.1
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2013-11-06  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06  7:52 Duan Jiong
2013-11-06  8:47 ` Uwe Kleine-König [this message]
2014-04-11  7:46 Duan Jiong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131106084743.GV14892@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=duanj.fnst@cn.fujitsu.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®