mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Haavard Skinnemoen <hskinnemoen@gmail.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] avr32: Remove HAVE_KPROBES from avr32 Kconfig
Date: Wed, 6 Nov 2013 16:28:44 -0500	[thread overview]
Message-ID: <20131106162844.76119e9e@gandalf.local.home> (raw)
In-Reply-To: <20131106210520.GA6825@samfundet.no>

On Wed, 6 Nov 2013 22:05:21 +0100
Hans-Christian Egtvedt <egtvedt@samfundet.no> wrote:

> Around Wed 06 Nov 2013 12:43:30 -0500 or thereabout, Steven Rostedt wrote:
> 
> Hello,
> 
> > Although there's a arch/avr32/kernel/kprobes.c file, this arch does not
> > compile with kprobes enabled:
> > 
> >  In file included from cross-linux.git/arch/avr32/kernel/kprobes.c:14:
> >  cross-linux.git/include/linux/kprobes.h: In function 'get_kprobe_ctlblk':
> >  cross-linux.git/include/linux/kprobes.h:358: error: invalid use of undefined type 'struct kprobe_ctlblk'
> >  cross-linux.git/include/linux/kprobes.h:358: error: dereferencing pointer to incomplete type
> >  make[2]: *** [arch/avr32/kernel/kprobes.o] Error 1
> > 
> > This is because it does not define the required kprobe_ctlblk struct,
> > and fails to compile when CONFIG_KPROBES is set.
> > 
> > Unfortunately, this also makes my testing of various configs for
> > different archs to fail on avr32 as well.
> > 
> > If kprobes is not supported by avr32 than do not say that it is.
> 
> kprobes is supposed to be supported on AVR32, but it seems to have broken
> somewhere down the road.
> 
> I re-discovered an old patch fixing this from Eirik, I have added this to my
> for-linus branch instead of your proposed patch.
> 
> https://git.kernel.org/cgit/linux/kernel/git/egtvedt/linux-avr32.git/log/?h=for-linus
> 

That works too! I was hoping for a similar fix. I sent my patch more as
an incentive to get kprobes fixed than to disable it ;-)

Tested-by: Steven Rostedt <rostedt@goodmis.org> # only cross compiled tested

-- Steve

      reply	other threads:[~2013-11-06 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 17:43 Steven Rostedt
2013-11-06 21:05 ` Hans-Christian Egtvedt
2013-11-06 21:28   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131106162844.76119e9e@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=egtvedt@samfundet.no \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®