From: Shawn Guo <shawn.guo@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata
Date: Thu, 7 Nov 2013 10:34:47 +0800 [thread overview]
Message-ID: <20131107023446.GC5994@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1383791180-3579-1-git-send-email-jszhang@marvell.com>
On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> We need to set mxs_phy rather as the platform drvdata so that we can get
> the correct mxs_phy in mxs_phy_remove().
>
> Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Change-Id should be dropped though.
Shawn
> ---
> drivers/usb/phy/phy-mxs-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index fdd33b4..545844b 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
>
> mxs_phy->clk = clk;
>
> - platform_set_drvdata(pdev, &mxs_phy->phy);
> + platform_set_drvdata(pdev, mxs_phy);
>
> ret = usb_add_phy_dev(&mxs_phy->phy);
> if (ret)
> --
> 1.8.4.2
>
next prev parent reply other threads:[~2013-11-07 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 2:26 Jisheng Zhang
2013-11-07 2:34 ` Shawn Guo [this message]
2013-11-07 2:36 ` Jisheng Zhang
2013-11-07 2:47 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107023446.GC5994@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®