From: Shawn Guo <shawn.guo@linaro.org>
To: Rongjun Ying <Rongjun.Ying@csr.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>, rjying <rjying@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Barry Song <Barry.Song@csr.com>
Subject: Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance
Date: Thu, 7 Nov 2013 12:55:42 +0800 [thread overview]
Message-ID: <20131107045540.GE5994@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <86130EF012BDF348AA0D464A4F4494780129542816@SHAASIEXM01.ASIA.ROOT.PRI>
On Thu, Nov 07, 2013 at 03:32:09AM +0000, Rongjun Ying wrote:
> I think my patch is better.
Well, unfortunately your patch is plainly wrong, because there are
in-tree users of voltage-tolerance right now. How can you simply remove
it from driver with ignoring these users?
$ git grep voltage-tolerance arch/arm/boot/dts
arch/arm/boot/dts/am33xx.dtsi: voltage-tolerance = <2>; /* 2 percentage */
arch/arm/boot/dts/imx27.dtsi: voltage-tolerance = <5>;
arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: voltage-tolerance = <1>; /* 1% */
arch/arm/boot/dts/r8a73a4-ape6evm.dts: voltage-tolerance = <1>; /* 1% */
arch/arm/boot/dts/sh73a0-kzm9g-reference.dts: voltage-tolerance = <1>; /* 1% */
Shawn
> All soc have a max work voltage. If regulator IC can't supply min voltage,
> It can supply max voltage to soc.
> As my patch, not need overwrite OPP in <board>.dts.
> As your comment above, almost all board need overwrite OPP, unless the regulator
> IC can supply all voltage ranges of SoC need.
prev parent reply other threads:[~2013-11-07 4:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 3:10 rjying
2013-11-05 4:38 ` Viresh Kumar
2013-11-05 11:53 ` Shawn Guo
2013-11-06 2:15 ` Rongjun Ying
2013-11-06 3:27 ` Shawn Guo
2013-11-07 1:55 ` Rongjun Ying
2013-11-07 2:26 ` Shawn Guo
2013-11-07 3:32 ` Rongjun Ying
2013-11-07 4:55 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107045540.GE5994@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=Barry.Song@csr.com \
--cc=Rongjun.Ying@csr.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rjying@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®