From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188Ab3KGMAs (ORCPT ); Thu, 7 Nov 2013 07:00:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869Ab3KGMAq (ORCPT ); Thu, 7 Nov 2013 07:00:46 -0500 Date: Thu, 7 Nov 2013 20:00:12 +0800 From: Dave Young To: Matt Fleming Cc: matt.fleming@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efi earlyprintk fix Message-ID: <20131107120012.GA4116@dhcp-16-126.nay.redhat.com> References: <20131103121647.GA4770@dhcp-16-126.nay.redhat.com> <20131104103739.GD21688@console-pimps.org> <20131104125853.GB5118@dhcp-16-126.nay.redhat.com> <20131106084921.GA22856@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131106084921.GA22856@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/13 at 08:49am, Matt Fleming wrote: > On Mon, 04 Nov, at 08:58:53PM, Dave Young wrote: > > On 11/04/13 at 10:37am, Matt Fleming wrote: > > > On Sun, 03 Nov, at 08:16:47PM, Dave Young wrote: > > > > > > > > there's below one line shift problem: > > > > > > > > ACPI=0xdabfe000 ACPI 2.0=0xdabfe014 SMBIOS=0xdaa9e000 > > > > [ 0.000000] efi: > > > > > > > > In fact check efi_y and the lfb_height should be compared at the begin of the > > > > loop of early_efi_write > > > > > > Hmm... this is interesting. I can't produce this on any of my machines. > > > Where did you see this? What hardware? > > > > It's my laptop Thinkpad T420, the screen scolls very fast, I use boot_delay=500 > > to verify it with my patch for moving boot_delay param an early param. > > Dave, how are you booting your laptop? Are you using grub? Does the > earlyprintk output start at the bottom of the screen? Do you set any > parameters for efifb? I tried both grub and efi stub. The messages seems come from the n-1 line of the screen. I did not set any parameters by myself.