From: Guenter Roeck <linux@roeck-us.net>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <robherring2@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Matt Porter <matt.porter@linaro.org>,
Koen Kooi <koen@dominion.thruhere.net>,
Alison Chaiken <Alison_Chaiken@mentor.com>,
Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
Michael Stickel <ms@mycable.de>,
Dirk Behme <dirk.behme@gmail.com>,
Alan Tull <delicious.quinoa@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Michael Bohan <mbohan@codeaurora.org>,
Ionut Nicu <ioan.nicu.ext@nsn.com>,
Michal Simek <monstr@monstr.eu>,
Matt Ranostay <mranostay@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] OF: Introduce utility helper functions
Date: Fri, 8 Nov 2013 11:10:39 -0800 [thread overview]
Message-ID: <20131108191039.GA25932@roeck-us.net> (raw)
In-Reply-To: <1383923040-24803-6-git-send-email-panto@antoniou-consulting.com>
On Fri, Nov 08, 2013 at 05:04:00PM +0200, Pantelis Antoniou wrote:
> Introduce helper functions for working with the live DT tree.
>
> __of_free_property() frees a dynamically created property
> __of_free_tree() recursively frees a device node tree
> __of_copy_property() copies a property dynamically
> __of_create_empty_node() creates an empty node
> __of_find_node_by_full_name() finds the node with the full name
> and
> of_multi_prop_cmp() performs a multi property compare but without
> having to take locks.
>
> Bug fix about prop->len == 0 by Ionut Nicu <ioan.nicu.ext@nsn.com>
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Hi Pantelis,
nitpick:
.git/rebase-apply/patch:77: trailing whitespace.
* no pointer exist for any properties. Only safe to do if you
.git/rebase-apply/patch:213: trailing whitespace.
* Find a node with the give full name by recursively following any of
.git/rebase-apply/patch:274: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
Guenter
prev parent reply other threads:[~2013-11-08 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 15:03 [PATCH v4 0/5] OF: Fixes in preperation of DT overlays Pantelis Antoniou
2013-11-08 15:03 ` [PATCH v4 1/5] OF: Introduce device tree node flag helpers Pantelis Antoniou
2013-11-08 15:03 ` [PATCH v4 2/5] OF: Clear detach flag on attach Pantelis Antoniou
2013-11-08 15:03 ` [PATCH v4 3/5] OF: export of_property_notify Pantelis Antoniou
2013-11-08 15:03 ` [PATCH v4 4/5] OF: Export all DT proc update functions Pantelis Antoniou
2013-11-08 15:04 ` [PATCH v4 5/5] OF: Introduce utility helper functions Pantelis Antoniou
2013-11-08 19:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108191039.GA25932@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Alison_Chaiken@mentor.com \
--cc=alexander.sverdlin@nsn.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinh.linux@gmail.com \
--cc=dirk.behme@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=ioan.nicu.ext@nsn.com \
--cc=jluebbe@lasnet.de \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.porter@linaro.org \
--cc=mbohan@codeaurora.org \
--cc=monstr@monstr.eu \
--cc=mranostay@gmail.com \
--cc=ms@mycable.de \
--cc=panto@antoniou-consulting.com \
--cc=robherring2@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®