mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: matt.fleming@intel.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi earlyprintk fix
Date: Sat, 9 Nov 2013 11:44:29 +0800	[thread overview]
Message-ID: <20131109034429.GA4294@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <20131108103648.GA2318@console-pimps.org>

On 11/08/13 at 10:36am, Matt Fleming wrote:
> On Thu, 07 Nov, at 08:09:06PM, Dave Young wrote:
> > Here is my debug message about the efifb params (all hex values):
> > [    0.000000] efi fb lfb width: 280
> > [    0.000000] efi fb lfb height: 1e0
> > [    0.000000] efi fb lfb base: e0000000
> > [    0.000000] efi fb lfb linelength: a00
> > [    0.000000] efi fb font height: 10
> > [    0.000000] efi fb font width: 8
> > 
> > The problem looks related to the pr_cont(), here is what I observed:
> > [    0.000000] efi: EFI v2.00 by Lenovo
> >                     ACPI=0xdabfe000  ACPI 2.0=0xdabfe014  SMBIOS=0xdaa9e000
> > [    0.000000] efi: 
> > 
> > After relooking the code, below fix is more reasonable than my original one,
> > But I still confused why it only happens on this machine.
> 
> Dave, could you try this patch?

Hi, Matt

Confirmed, your patch work ok for the pr_cont issue.

Actually I mixed two problems in my report, one is there's always one blank line
at the bottom of screen, the other is the pr_cont issue. For the second problem
change >= to > looks better. For the previous problem still need to move the
hunk below to the beginning point of early_efi_write function. It just works for me
but I'm not sure why this is not necessary for other machines. 

+		if (efi_y + font->height > si->lfb_height) {
+			u32 i;
+
+			efi_y -= font->height;
+			early_efi_scroll_up();
+
+			for (i = 0; i < font->height; i++)
+				early_efi_clear_scanline(efi_y + i);
+		}


> 
> ---
> 
> diff --git a/arch/x86/platform/efi/early_printk.c b/arch/x86/platform/efi/early_printk.c
> index 6599a0027b76..81b506d5befd 100644
> --- a/arch/x86/platform/efi/early_printk.c
> +++ b/arch/x86/platform/efi/early_printk.c
> @@ -142,7 +142,7 @@ early_efi_write(struct console *con, const char *str, unsigned int num)
>  			efi_y += font->height;
>  		}
>  
> -		if (efi_y + font->height >= si->lfb_height) {
> +		if (efi_y + font->height > si->lfb_height) {
>  			u32 i;
>  
>  			efi_y -= font->height;
> -- 
> Matt Fleming, Intel Open Source Technology Center

  reply	other threads:[~2013-11-09  3:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 12:16 Dave Young
2013-11-04 10:37 ` Matt Fleming
2013-11-04 12:58   ` Dave Young
2013-11-06  8:49     ` Matt Fleming
2013-11-07 12:00       ` Dave Young
2013-11-06  9:23     ` Dave Young
2013-11-06  9:38       ` Matt Fleming
2013-11-07 12:09         ` Dave Young
2013-11-08 10:36           ` Matt Fleming
2013-11-09  3:44             ` Dave Young [this message]
2013-11-11 16:13               ` Matt Fleming
2013-11-12  2:22                 ` Dave Young
2013-12-18  9:52     ` Dave Young
2013-12-18 10:31       ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131109034429.GA4294@dhcp-16-126.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®