Re: [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels

[Lee Jones <lee.jones@linaro.org>]

On Mon, 11 Nov 2013, Chanwoo Choi wrote:

> On 11/11/2013 07:53 PM, Lee Jones wrote:
> >> On 11/08/2013 10:19 PM, Charles Keepax wrote:
> >>> Improve readability by creating a define for each microphone detection
> >>> level.
> >>>
> >>> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> >>> ---
> >>>  drivers/extcon/extcon-arizona.c       |   21 ++++++++++++++++-----
> >>>  include/linux/mfd/arizona/registers.h |    9 +++++++++
> >>>  2 files changed, 25 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> >>> index 3c55ec8..6d914ba 100644
> >>> --- a/drivers/extcon/extcon-arizona.c
> >>> +++ b/drivers/extcon/extcon-arizona.c
> >>> @@ -44,6 +44,17 @@
> >>>  #define HPDET_DEBOUNCE 500
> >>>  #define DEFAULT_MICD_TIMEOUT 2000
> >>>  
> >>> +enum {
> >>> +	MICD_LVL_1_TO_7 = ARIZONA_MICD_LVL_1 | ARIZONA_MICD_LVL_2 |
> >>> +			  ARIZONA_MICD_LVL_3 | ARIZONA_MICD_LVL_4 |
> >>> +			  ARIZONA_MICD_LVL_5 | ARIZONA_MICD_LVL_6 |
> >>> +			  ARIZONA_MICD_LVL_7,
> >>> +
> >>> +	MICD_LVL_0_TO_7 = ARIZONA_MICD_LVL_0 | MICD_LVL_1_TO_7,
> >>> +
> >>> +	MICD_LVL_0_TO_8 = MICD_LVL_0_TO_7 | ARIZONA_MICD_LVL_8,
> >>> +};
> >>
> >> MICD_LVL_1_TO_7 / MICD_LVL_0_TO_7 /MICD_LVL_0_TO_8 haven't the sequential value.
> >> I prefer '#define' keyword to define MICD_LVL_1_TO_7 / MICD_LVL_0_TO_7 /MICD_LVL_0_TO_8
> >> instead of enum keyword.
> > 
> > Actually Charles has already sent me this patch and I applied it a
> > while ago.
> 
> Why did you applied extcon driver patch on your tree?

Good point, well presented!

I should have just Acked the MFD parts in this case.

It's not too late to pull it back - I'll do just that.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog