From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755300Ab3KKTdR (ORCPT ); Mon, 11 Nov 2013 14:33:17 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:42620 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270Ab3KKTdA (ORCPT ); Mon, 11 Nov 2013 14:33:00 -0500 Date: Mon, 11 Nov 2013 19:32:36 +0000 From: Russell King - ARM Linux To: Jonathan Austin Cc: Ming Lei , Michal Marek , Rusty Russell , Linux Kernel Mailing List , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Axel Lin , linux-arm-kernel Subject: Re: kernel BUG at kernel/kallsyms.c:222! Message-ID: <20131111193236.GB16735@n2100.arm.linux.org.uk> References: <87y54vzszo.fsf@rustcorp.com.au> <528110B1.4060402@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <528110B1.4060402@arm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2013 at 05:15:29PM +0000, Jonathan Austin wrote: > I've tested the patch below and it solves the ARM side of things - so > gives you an option other than a complete revert. Happy to put this in to > RMK's patch system if you'd prefer not to have to revert and he's happy > with the patch. I think this is the right solution because it then means that this symbol has the same meaning whether on MMU or !MMU - and getting rid of these kinds of gratuitous variances are the only way that !MMU is going to become less fragile.