mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, joe@perches.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c
Date: Mon, 11 Nov 2013 16:15:40 -0800	[thread overview]
Message-ID: <20131112001540.GA26611@kroah.com> (raw)
In-Reply-To: <1383309116-8042-1-git-send-email-conrad.s.j.gomes@gmail.com>

On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote:
> This is a patch which fixes  coding style issues in unioxx5.c found
> by checkpatch.pl
> 
> 1) Replaced printk with pr_info and pr_err

Drivers should never call printk() as they all have access to a struct
device somewhere.  So please call dev_info() or dev_err() instead.

> 2) Reinitialized n_subd before for loop to fix over 80 character
>    warning
> 3) Reworded comment to fix 80 character warning
>

Patches should do one thing, not 3 things.  Care to break this up into
"one logical change per patch"?  Yes, it's a small thing, but if you had
done this already, I could have taken the other 2 patches and you would
have just had to redo one patch in this series...

thanks,

greg k-h

  reply	other threads:[~2013-11-12  7:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 12:31 Conrad Gomes
2013-11-12  0:15 ` Greg KH [this message]
     [not found]   ` <CALxff2GmatgMQF_2yQ9g=tZzh=J-5fKt89sFAU4oYq_FBJHNag@mail.gmail.com>
2013-11-18 10:40     ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131112001540.GA26611@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=conrad.s.j.gomes@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome