From: Peter Zijlstra <peterz@infradead.org>
To: "Wang, Xiaoming" <xiaoming.wang@intel.com>
Cc: Paul Turner <pjt@google.com>, Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>,
"Zhang, Dongxing" <dongxing.zhang@intel.com>
Subject: Re: [PATCH] [sched]: pick the NULL entity caused the panic.
Date: Tue, 12 Nov 2013 09:25:49 +0100 [thread overview]
Message-ID: <20131112082549.GH5056@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <FA47D36D6EC9FE4CB463299737C09B9901B6D847@SHSMSX102.ccr.corp.intel.com>
On Tue, Nov 12, 2013 at 06:38:24AM +0000, Wang, Xiaoming wrote:
> Dear Paul
> How about moving cfs_rq->nr_running into loop. What I worried is that cfs_rq->nr_running
> may zero because cfs_rq is coming from cfs_rq = group_cfs_rq(se) again. We haven't known the
> reproduction exactly, panic happened only on random test and unstable.
No; its just plain wrong. If this new condition can be true there's
something fundamentally messed up and we need to figure out what causes
that, not try and paper it over.
prev parent reply other threads:[~2013-11-12 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 16:29 Wang, Xiaoming
2013-11-12 3:09 ` Paul Turner
2013-11-12 6:38 ` Wang, Xiaoming
2013-11-12 8:25 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112082549.GH5056@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chuansheng.liu@intel.com \
--cc=dongxing.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=xiaoming.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®