From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758917Ab3KMRsv (ORCPT ); Wed, 13 Nov 2013 12:48:51 -0500 Received: from merlin.infradead.org ([205.233.59.134]:35708 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173Ab3KMRsm (ORCPT ); Wed, 13 Nov 2013 12:48:42 -0500 Date: Wed, 13 Nov 2013 18:48:26 +0100 From: Peter Zijlstra To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, riel@redhat.com, mgorman@suse.de, tglx@linutronix.de, prarit@redhat.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:sched/urgent] sched/numa: Fix NULL pointer dereference in task_numa_migrate() Message-ID: <20131113174826.GR21461@twins.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 13, 2013 at 09:25:22AM -0800, tip-bot for Rik van Riel wrote: > + if (unlikely(!sd)) { > + p->numa_preferred_nid = cpu_to_node(task_cpu(p)); 't is only now I notice, but I added a convenience helper for this: task_node(p) :-) No biggie, I'll try and remember when next something near there needs changing.