From: Pete Zaitcev <zaitcev@redhat.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>, Erik Jacobson <erikj@sgi.com>,
Andrew Morton <akpm@osdl.org>, Matt Helsley <matthltc@us.ibm.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
zaitcev@redhat.com
Subject: Re: [PATCH] connector: improved unaligned access error fix
Date: Thu, 14 Nov 2013 12:45:49 -0700 [thread overview]
Message-ID: <20131114124549.7b5f3a7b@lembas.zaitcev.lan> (raw)
In-Reply-To: <201311141743.rAEHhuEV004998@farm-0012.internal.tilera.com>
On Thu, 14 Nov 2013 12:09:21 -0500
Chris Metcalf <cmetcalf@tilera.com> wrote:
> - __u8 buffer[CN_PROC_MSG_SIZE];
> + __u8 buffer[CN_PROC_MSG_SIZE] __aligned(8);
> - msg = (struct cn_msg *)buffer;
> + msg = buffer_to_cn_msg(buffer);
> ev = (struct proc_event *)msg->data;
> memset(&ev->event_data, 0, sizeof(ev->event_data));
Why is memset(buffer,0,CN_PROC_MSG_SIZE) not acceptable?
-- Pete
next prev parent reply other threads:[~2013-11-14 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 17:09 Chris Metcalf
2013-11-14 19:45 ` Pete Zaitcev [this message]
2013-11-14 21:22 ` Chris Metcalf
2013-11-14 22:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114124549.7b5f3a7b@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=akpm@osdl.org \
--cc=cmetcalf@tilera.com \
--cc=erikj@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®