From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349Ab3KNOqV (ORCPT ); Thu, 14 Nov 2013 09:46:21 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:59454 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361Ab3KNOqM (ORCPT ); Thu, 14 Nov 2013 09:46:12 -0500 Date: Thu, 14 Nov 2013 14:46:00 +0000 From: Mark Rutland To: Alexander Shiyan Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Samuel Ortiz , Lee Jones , "grant.likely@linaro.org" , "rob.herring@calxeda.com" Subject: Re: [PATCH] mfd: syscon: Allow to using subdevices Message-ID: <20131114144559.GC28328@e106331-lin.cambridge.arm.com> References: <1384433523-30602-1-git-send-email-shc_work@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384433523-30602-1-git-send-email-shc_work@mail.ru> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2013 at 12:52:03PM +0000, Alexander Shiyan wrote: > This patch adds support for using subdevices within syscon node. > Primary usage of this is describe all devices with same memory > region in one container. I think if you need to do this, you should not be using syscon. What exactly is your use-case? I don't like the idea of treating syscon like a bus or container in this fashion. Mark. > > Signed-off-by: Alexander Shiyan > --- > drivers/mfd/syscon.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > index 71841f9..6e9244a 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, syscon); > > + if (of_platform_populate(dev->of_node, NULL, NULL, dev)) > + dev_warn(dev, "Fail to create subdevices\n"); > + > dev_info(dev, "regmap %pR registered\n", res); > > return 0; > -- > 1.8.1.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >